Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pause when running and separate the RunThreadLogic #30

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Add Pause when running and separate the RunThreadLogic #30

merged 2 commits into from
Dec 14, 2023

Conversation

zsq001
Copy link
Contributor

@zsq001 zsq001 commented Dec 11, 2023

This commit separated the Run thread from the StartRun function and added the pause function. But due to my poor .Net development knowledge, there might be some tiny problems of the progress bar and button placement. I would really appreciate it if you can fix it.

@Mythologyli
Copy link
Owner

Thank you!
It might take me a bit of time to review the PR. As I currently don't have an iOS device, I may need your assistance in testing.

@zsq001
Copy link
Contributor Author

zsq001 commented Dec 11, 2023

I have already tested on iOS 16.1, iPhone 12 , everything seems fine, the running function and the pause function works normally. I will test on another device iOS 16.4 dev Beta, iPhone 8 tomorrow to ensure it really works.

@zsq001
Copy link
Contributor Author

zsq001 commented Dec 12, 2023

I have tested on iOS 16.4 dev Beta, iPhone 8, everything goes well. A 5km record has benn successfully uploaded to the school running software. x)

@Mythologyli Mythologyli merged commit 3ecb4d3 into Mythologyli:master Dec 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants